-
Notifications
You must be signed in to change notification settings - Fork 5
(#4993) Accordion No Nesting Headers #2096
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Viewing Information |
f8062bf to
478b796
Compare
6d8e133 to
1670e82
Compare
bryanpizzillo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am going to start with this big one as it will help to define what exactly is going on in the code.
packages/ncids-js/src/components/usa-accordion/usa-accordion-options.ts
Outdated
Show resolved
Hide resolved
1670e82 to
95d74e8
Compare
packages/ncids-js/src/components/usa-accordion/usa-accordion.component.ts
Fixed
Show fixed
Hide fixed
3816f55 to
02a632d
Compare
|
@karlikpj The only issues I'm seeing is that the 8px spacing in between the accordions is missing and that some h2's are showing up as Open Sans and not Poppins |
b8e43c0 to
ec57c61
Compare
|
@karlikpj when h2s become accordions, the accordion headings should be Open Sans and not Poppins |
23bba53 to
4d1c806
Compare
997ab3f to
092eb03
Compare
092eb03 to
1e11c8f
Compare
blilianyu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Passes for design cc: @andyvanavery31
The review was discussed and a different approach was taken, so the review is out of date.

Closes #2098
Pull Request Details
Add description
Closes #
Author PR Checklist
Items that the author of the PR is responsible for checking before submitted the PR.
General:
Accessibility:
Development:
Product Reviewer PR Checklist
Items the product team is responsible for reviewing.
General:
Accessibility:
Design Reviewer PR Checklist
Items the design team is responsible for reviewing.
General:
Developer Reviewer PR Checklist
Items the development team is responsible for reviewing.
General:
Accessibility: