Skip to content

Conversation

@karlikpj
Copy link
Contributor

@karlikpj karlikpj commented Dec 9, 2025

Closes #2098

Pull Request Details

Add description

Closes #

Author PR Checklist

Items that the author of the PR is responsible for checking before submitted the PR.

General:

  • I have reviewed the acceptance criteria defined in the ticket and ensured the work has been completed.
  • The commit message passes all quality commit message standards.
  • Unit tests have been updated or created to reflect any javascript changes.
  • Storybook scenarios have been updated or created to reflect any html/css/js changes.

Accessibility:

  • WCAG 2.1 Level AA requirements have been met.

Development:

  • Any new or updated javascript code has 100% unit test coverage.
  • New or updated breakpoints have regression images.
  • Breaking changes have been thoroughly documented in the PR.

Product Reviewer PR Checklist

Items the product team is responsible for reviewing.

General:

  • There are no unexpected or unapproved regression image changes.

  • Functionality of interactive elements meet the acceptance criteria.
  • The product is visually and functionally the same across the different browsers.

Accessibility:

  • AxeDev Tools: there are no new or outstanding accessibility issues introduced in this PR.
  • Lighthouse: scores have not noticeably decreased during this PR.
  • Wave: there are no new errors or contrast errors introduced in this PR.

Design Reviewer PR Checklist

Items the design team is responsible for reviewing. 


General:

  • New or updated features introduced in this PR are developed mobile-first.
  • Breakpoint changes and regression images match those breakpoints.
  • This PR has been tested in all supported browsers at all breakpoints.

Developer Reviewer PR Checklist

Items the development team is responsible for reviewing.

General:

  • New code passes code quality standards set by industry standards.
  • The expected Storybook stories have been added or updated for the new or updated feature.
  • The expected unit tests have been added or updated for the new or updated feature.

Accessibility:

  • VoiceOver: Described content matches with what was expected.
  • Keyboard navigation: new or updated features and content are navigable via the keyboard.

@github-actions
Copy link

github-actions bot commented Dec 9, 2025

Copy link
Member

@bryanpizzillo bryanpizzillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am going to start with this big one as it will help to define what exactly is going on in the code.

@karlikpj karlikpj force-pushed the ticket/4993-accordion-first-header branch from 1670e82 to 95d74e8 Compare December 13, 2025 20:21
@karlikpj karlikpj force-pushed the ticket/4993-accordion-first-header branch 5 times, most recently from 3816f55 to 02a632d Compare December 15, 2025 13:25
@karlikpj
Copy link
Contributor Author

@blilianyu
Copy link
Contributor

blilianyu commented Dec 16, 2025

@karlikpj The only issues I'm seeing is that the 8px spacing in between the accordions is missing and that some h2's are showing up as Open Sans and not Poppins

@karlikpj karlikpj force-pushed the ticket/4993-accordion-first-header branch 4 times, most recently from b8e43c0 to ec57c61 Compare December 16, 2025 19:24
@bennettcc bennettcc requested a review from a team December 17, 2025 14:50
@blilianyu
Copy link
Contributor

@karlikpj when h2s become accordions, the accordion headings should be Open Sans and not Poppins
Screenshot 2025-12-18 at 11 21 25 AM

@karlikpj karlikpj force-pushed the ticket/4993-accordion-first-header branch 2 times, most recently from 23bba53 to 4d1c806 Compare December 18, 2025 18:13
@karlikpj karlikpj force-pushed the ticket/4993-accordion-first-header branch 3 times, most recently from 997ab3f to 092eb03 Compare December 18, 2025 19:05
@karlikpj karlikpj force-pushed the ticket/4993-accordion-first-header branch from 092eb03 to 1e11c8f Compare December 18, 2025 20:46
Copy link
Contributor

@blilianyu blilianyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passes for design cc: @andyvanavery31

@bryanpizzillo bryanpizzillo dismissed their stale review December 19, 2025 19:58

The review was discussed and a different approach was taken, so the review is out of date.

@bryanpizzillo bryanpizzillo merged commit c8732d1 into develop Dec 19, 2025
8 of 10 checks passed
@bryanpizzillo bryanpizzillo deleted the ticket/4993-accordion-first-header branch December 19, 2025 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

5 participants